Skip to content
OverviewSolutions
7
Comments
3
Rafael La Buonora
@rlabuonora

All comments

  • Rafael La Buonora•160
    @rlabuonoraSubmitted almost 3 years ago

    I got in trouble getting the sizing of the nested grids right (specially the testimonials section). Any help would be greatly appreciated!

    Nested Grids and Flexbox

    2
    Rafael La Buonora•160
    @rlabuonoraPosted almost 3 years ago

    Hi! Thanks a lot for your feedback. I recoded the layout to solve some of the problems you pointed out.

    I focused mainly on the layout because I'm trying to learn that, so I didn't implement the semantic html suggestions. I'll probably revisit it in a few days for those.

    Thanks again!

    1
  • CodingDuck•390
    @KaskaS-OSubmitted about 3 years ago

    Hi everyone!

    This was my first challenge which required some more js. I'd be grateful if you could give me some feedback, especially about js. I had some problems with handling NaN values (e.g. when the last character is '.' or ',') in my live counting function. But in the end it works ;)

    Thanks in advance for any remarks!

    Kaska

    Responsive app using CSS Grid, Flexbox and JS

    1
    Rafael La Buonora•160
    @rlabuonoraPosted about 3 years ago

    Great job! The only detail I can point to is that you allow negative numbers for total bill and number of people.

    I submitted a solution yesterday and it has a some problems, reviewing yours was super helpful. This is a great work, congrats!

    Marked as helpful
    0
  • Rafael La Buonora•160
    @rlabuonoraPosted over 4 years ago

    Great solution! Adding to what Martin said above about centering and transitions (I haven't implemented transitions on my solution either), I noticed the next and previous slide buttons are in the middle of the image.

    I used absolute positioning to solve that, here is my solution in case you are interested:

    https://www.frontendmentor.io/solutions/plain-css-and-js-solution-2I4ATIl5l

    0