Skip to content
Submitted about 3 years ago

Responsive app using CSS Grid, Flexbox and JS

CodingDuck•390
@KaskaS-O
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Tip calculator app
  • HTML
  • CSS
  • JS
2junior

Design comparison

SolutionDesign

Solution retrospective

Hi everyone!

This was my first challenge which required some more js. I'd be grateful if you could give me some feedback, especially about js. I had some problems with handling NaN values (e.g. when the last character is '.' or ',') in my live counting function. But in the end it works ;)

Thanks in advance for any remarks!

Kaska

Community feedback

  • Rafael La Buonora•160
    @rlabuonoraPosted about 3 years ago

    Great job! The only detail I can point to is that you allow negative numbers for total bill and number of people.

    I submitted a solution yesterday and it has a some problems, reviewing yours was super helpful. This is a great work, congrats!

    Marked as helpful
    0
    CodingDuck•390
    @KaskaS-OPosted about 3 years ago

    @rlabuonora Hi! Thank a lot! You're completely right, I haven't even thought about negative numbers. I'll definately fix it :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord