Skip to content
OverviewSolutions
10
Comments
6
Rizky Firman Syah
@rizfirsy-gh

All comments

  • Rizky Firman Syah•215
    @rizfirsy-ghPosted over 2 years ago

    Hi, thank you! I didn't realize to use blockquote instead of div since I rarely use it. It's revised now😉. The accessibility issue said my HTML should have at least one level one heading(h1) but I think I don't have to use it for this challenge.

    0
  • Rizky Firman Syah•215
    @rizfirsy-ghPosted over 3 years ago

    Please forgot the error message from this website. That was not important and will not rise any problem

    0
  • Rizky Firman Syah•215
    @rizfirsy-ghPosted almost 4 years ago

    Yo do great Yustina! Love it! Btw I am also Magelang based. Glad to see you here.

    0
  • Rizky Firman Syah•215
    @rizfirsy-ghPosted almost 4 years ago

    Hi, Nourhan 👋. Your solution is not responsive on some devices and you have some issues there. I appreciate your decision to use CSS grid and it's good by the way.

    Your issues:

    1. You do not set media queries to around 375 - 1440 px so this will not responsible for sizes other than1440 and 375.
    2. Some element and text styling(e.g padding, margin, font size, font weight) is not the same or close to the design template.

    I hope you got my thoughts. happy coding!

    0
  • Rizky Firman Syah•215
    @rizfirsy-ghPosted almost 4 years ago

    Hi @ irosen419 you do great and everything works fine even though you are missing some statistic elements, but I don't care. Let's focus on your question. During my experience as a beginner, using rem for everything is not a very good thing and it creates other bugs when we work on other complex projects. Maybe we won't find the problem in a simple project, but we'll face it when we do it (use brakes for everything) for other complex jobs.

    My tips:

    1. Use rem for font-size and padding.
    2. Use em for your margins.
    3. Use px or % to measure your elements. I don't guarantee this 100% but I work on it for all my projects, so I'm confident enough to share it with you.

    Hope this provides a reference, Thank you

    0
  • Dogukan Varis•580
    @varisDogukanSubmitted almost 4 years ago

    I don't have any experience with naming classes. Can you help me for this?

    Html and Css

    2
    Rizky Firman Syah•215
    @rizfirsy-ghPosted almost 4 years ago

    Hi Dova, to write a class we just needed to write a simple class name that represent the contents of the element. Example: When we have a div element that contain a fish image, we can give it a class name fish-image.

    <div class="fish-image"> </div>
    1