Design comparison
SolutionDesign
Solution retrospective
Any feedback would be appreciated ..
Community feedback
- @rizfirsy-ghPosted almost 4 years ago
Hi, Nourhan 👋. Your solution is not responsive on some devices and you have some issues there. I appreciate your decision to use CSS grid and it's good by the way.
Your issues:
- You do not set media queries to around 375 - 1440 px so this will not responsible for sizes other than1440 and 375.
- Some element and text styling(e.g padding, margin, font size, font weight) is not the same or close to the design template.
I hope you got my thoughts. happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord