I am learning coding for 06 months. I found CSS a little bit of time talking. I have used vanilla javascript. In but future I will use react.js. Otherwise, the project is quite easy.
I think I am using too much CSS. Can it be minimized?
I have seen many tutorials and videos. I am unsure about the best practice of coding.
Please help me with feedback on my project (01 to 10) with details, so that I can understand how much I learned.
Thanks everyone.
Regarding the HTML, I have seen one crucial mistake: Never use the same ID for more than one element. IDs should always be unique and they are used to identify one element. Having one ID for different elements is the same as 5 people using the same passport number, which is impossible 😅.
Furthermore, the code for the notifications count could be modified:
Old code
<div class="notify-icon">
<p>Notifications <span><button>3</button></span></p>
</div>
New code
<div class="notify-icon">
<p>Notifications <span><div id="notifications-count">3</div></span></p>
</div>
I see you have not coded to show zero when the Mark all as read button is pressed. You could add this to the Mark all as read code in Javascript:
const notificationsCount = document.getElementById("notifications-count")
notificationsCount.textContent = 0
This should make the counter reset to zero.
I am learning coding for 06 months. I found CSS a little bit of time talking. I have used vanilla javascript. In but future I will use react.js. Otherwise, the project is quite easy.
I think I am using too much CSS. Can it be minimized?
I have seen many tutorials and videos. I am unsure about the best practice of coding.
Please help me with feedback on my project (01 to 10) with details, so that I can understand how much I learned.
Thanks everyone.
Hello Kazi. I hope you are doing great.
Seen the files in the repository and I have some tips for you:
Regarding your CSS code, I would advise to break down the project in your head or on paper before actually diving into the project itself. By doing this, the objective is to see which <div> or other elements have the same children inside.
For example, in your case, you have a notification which always contains an <img> and 2 <p>, meaning that the styling of one notification will be the same for the other ones.
Let's see how can we refactor your code. There are two ways to do this:
Your old code:
.not01{
margin-bottom: 10px;
background-color: hsl(210, 60%, 98%);
border-radius: 10px;
padding: 10px;
}
.not02{
margin-top: 10px;
background-color: hsl(210, 60%, 98%);
border-radius: 10px;
padding: 10px;
}
.not03{
margin-bottom: 10px;
background-color: hsl(210, 60%, 98%);
border-radius: 10px;
padding: 10px;
}
Method 1 The first way would to group all of the different classes:
.not01, .not02, .not03, .not04 {
margin-bottom: 10px;
background-color: hsl(210, 60%, 98%);
border-radius: 10px;
padding: 10px;
}
Why is this method not efficient? Imagine you had a real application where there would be THOUSANDS of notifications. You would have to manually add each one (.not01, ... , .not847, .not848, etc)
Another thing is that your application would not be so dynamic, because the classes would be hard-coded into every element, one by one. Which would lead you to show a limited number of notifications to the user (no one would want to write up to .not500 😆).
The second way would be to create one class for all the <div> elements, which would be the correct method:
Method 2
.notification {
margin-bottom: 10px;
background-color: hsl(210, 60%, 98%);
border-radius: 10px;
padding: 10px;
}
This way every child's style would follow as:
.notification img{
float: left;
margin-top: -8px;
margin-right: 10px;
}
.notification p a:first-child{
color: black;
text-decoration: none;
font-weight: 800;
cursor: pointer;
}
.notification p a:last-child{
color: hsla(224, 21%, 14%, 0.714);
text-decoration: none;
font-weight: 800;
cursor: pointer;
}
And the best part? You would only write once for every notification :)
If you have any questions, I will do my best to answer them.
Happy coding!