Skip to content
OverviewSolutions
20
Comments
10
ERIC
@ricoom

All comments

  • ERIC•580
    @ricoomPosted about 1 year ago

    Hello @Osereme congratulations on completing this challenge. I have some few observations that I believe may help you improve your code. 1.make use of the JavaScript Validation API to avoid reinventing the wheel and get the best from html5. the API has methods that enable you to not only check for input errors but also give you ready messages to display to client. you can achieve this by adding a span to the input. input.checkValidtiy() is one of the useFul methods that come in handy in this challenge. eg.

    submit.addEventListener('click',(e)=>{ e.preventDefault();

    if(input.checkValidity()){

   // some code
}else{

    //display error err.innerText=input.validationMessage; }

    })

    2.mark the email input as required to avoid creating hardcoded not-null message. I hope you find these observation helpful. happy coding 😉

    Marked as helpful
    0
  • ERIC•580
    @ricoomPosted about 1 year ago

    Congratulations on completing this challenge, i like your application of grid but i advice you make use of grid-column and row span in the cards. Also try grid-template-columns(auto-fil, minmax(--params--) ) to get responsive cards. This would significantly save your time and reduce verbosity. For the mobile view, save your time by simply giving the container a block display, which will automatically stack the cards in one column. i hope you find this helpful. Happy coding 😊

    Marked as helpful
    1
  • _nehal💎•6,710
    @NehalSahu8055Submitted over 1 year ago

    👋Hello, Frontend Mentor coding community.

    👨🏼‍💻This is my solution for the Testimonials Grid Section.

    • Completely responsive

    I'll be happy to hear any feedback and advice!🤗

    Responsive testimonials grid section using flex

    1
    ERIC•580
    @ricoomPosted about 1 year ago

    Hello Nehal, Congratulations for completing the challenge. I would like to point out however that using CSS grid to layout the cards would have saved you a lot of time and give you cleaner code. The real difference between using Flexbox and CSS Grid is in the amount of code: The code for creating a complex layout in Flexbox is more verbose, dispersed and hard to debug (as it being one dimensional you had to create several containers), while that created with the Grid (two dimensional layout) is much faster, tidier and simpler. Though flexbox performance may be high in complex scenarios, the performance difference is almost negligible. Note: I don't mean flex is bad, in fact you need both to achieve this, I just meant for this specific challenge grid would be good, notwithstanding browser support for flexbox is broader than the latter. I hope you find this insight helpful. Happy coding!!😉

    Marked as helpful
    1
  • Saad Hisham•1,750
    @Saad-HishamSubmitted over 1 year ago

    I really enjoyed this feedback is welcome 😀 Hi🙋‍♂️ there the solution stopped working because the provided API require a subscription to keep working I'm sorry for that

    IP Address Tracker Solution

    3
    ERIC•580
    @ricoomPosted about 1 year ago

    Hello, congratulations on completing the challenge, i have some remarks that i believe if implemented could improve the user experience. Please add a placeholder in the input field. I believe you are a ware that a placeholder attribute specifies a short hint that describes the expected value of an input field. In conclusion, you IP tracker should be able to use either IP address or a domain name as a parameter, according to the set challenge. Happy coding 😊

    Marked as helpful
    1
  • ERIC•580
    @ricoomPosted about 1 year ago

    Hi i was no able to track any IP address, please get the geo locations from the IPFY api so that you can you them to update you leaflet map. Also check on mobile responsiveness, as it was not very responsive on my mobile device. Well done good job

    0
  • ERIC•580
    @ricoomPosted about 1 year ago

    Congratulations on completing your challenge. You IP address tracker should be able to track using either IP address or domain name. Good job

    0
  • Reno08-code•300
    @Reno08-codeSubmitted over 1 year ago

    Hi lovely people I have reuploaded my solution with JS this time. Please can you help me to improve my JS that it does not look repetitive.. Thank you :)

    Intro-component-with-sign-up-form

    2
    ERIC•580
    @ricoomPosted over 1 year ago

    Hi Reno08, Congratulations on completing your challenge. you have superbly aced the it💪. please try to make the intro part bolder, this can create an experience that stands out, truly captures the audience and, crucially, gives you the edge in the market. But boldness doesn't necessarily mean wacky or controversial.

    Marked as helpful
    0
  • ERIC•580
    @ricoomPosted almost 2 years ago

    Hello Eduardo, Congratulations on completing this challenge. I have noted the app is not responsive in small devices. You can use media query to adjust the size of the card for screens with width less than 375px.

    @media only screen and (max-width:375px) {

    }

    Marked as helpful
    1
  • 👾 Ekaterine Mitagvaria 👾•7,600
    @catherineisonlineSubmitted almost 2 years ago

    Hello, Frontend Mentor community! This is my solution to the Intro section with dropdown navigation.

    I appreciate all the feedback you left that helped me to improve this project. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.

    You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.

    Thank you

    Intro section with dropdown navigation

    9
    ERIC•580
    @ricoomPosted almost 2 years ago

    Hello Ekaterine, Congratulations!! you aced this challenge. I have some insights that may help you.

    • in your media query use 375px as max-width to ensure responsiveness in mobile devices. -Reduce the font size of your intro header on small devices. nevertheless, I do love the idea of a sticky hamburger, on scroll. good job!
    0
  • ERIC•580
    @ricoomPosted almost 2 years ago

    Hey, i love your approach to the solution. Please try to comment your code to make it easy for someone else to understand. And some transition when submitting to improve the UX Good job!

    0