@ahmetwithat
Submitted
Any advices on what semantic tag i could have or should have used for the <section>
tags would be appreciated.
@reza-sjdn
@ahmetwithat
Submitted
Any advices on what semantic tag i could have or should have used for the <section>
tags would be appreciated.
@reza-sjdn
Posted
Hey dear Ahmet
Instead of section
s, you could use article
s and it's more suitable because of the independence of client reviews!
But your style is great and almost pixel-perfect! Good Luck
Marked as helpful
@G0maa
Submitted
Hello again :)
I think this is not the best "responsive" implementation (if it is π¬), so I appreciate any reviews I get.
Thanks in advance.
@reza-sjdn
Posted
Hi @OoMiDOoO, Good Job!
Your work at mobile view is great but at desktop view is a little bad. Set width: 50%
and height: 100%
for the #perfume-img
. This way it will likely be ok.
but anyway Keep going your journey!
@YoungZV
Submitted
Any feedback is help me to be better and better. Thank you.
@reza-sjdn
Posted
hey @YoungZV, Good Job
I have some recommendations for you.
margin-top: 1rem
for .article__2
through .article__5
. You didn't really need that. Instead, increase the gap between articles. This causes article__1
and article__2
to not being on the same line in desktop view!h1
elements and this is not allowed in semantic html! Instead use p
or h2
through h6
elements.Except of above, You made it successfully!
Marked as helpful
@Kitezh1
Submitted
I found it difficult to use the media queries, to convert it to mobile design. Specifically I'm not sure why the 100vh wouldn't work for the mobile screen size. Any tips are appreciated.
@reza-sjdn
Posted
Hey @Kitezh1,
I liked your solution. It was PERFECT!
About why height: 100vh;
doesn't work at mobile view, in fact height: 100vh;
is a fixed length and to be flexible you must set min-height: 100vh;
That's it! Good Luck
@Mohammad-Mahfoud
Submitted
Hello, this is my first time doing Front-End Mentor Challenges so please give me feedbacks to improve my skills. Thanks :) .
@reza-sjdn
Posted
hey @Mohammad-Mahfoud
The structure of your solution(not considering its responsibility) is great. Only I guess you haven't read style guide file at all. Match your solution's style with the style guide.
@ribeiroLevi
Submitted
Feel free to tell me about any mistakes ou things i didn't do in the best way, any feedback is welcome, thanks in advance :)
@reza-sjdn
Posted
hello dear @ribeiroLevi, well done, everything's almost perfect but
anyway, your attempt is worth a lot!
@DezzaAnnePeregrina
Submitted
@reza-sjdn
Posted
Hi @DezzaAnnePeregrina, Good Job! Overall your solution is great but I have some small fixes to make your solution more responsive.
In CSS file:
.card
, set max-width: 900px;
..card__item
, instead of width: 19rem;
type flex: 1;
.@media
, set the break-point at max-width: 687px
.@media
in selector .card
, set the margin: 2rem;
3.5rem is much.
besides, if you set border-radius: 10px;
, it would be more beautiful!I hope It will help you. GOOD LUCK : )
Marked as helpful
@sandrvvu
Submitted
@reza-sjdn
Posted
Hey @sandrvvu, I have some advises for your solution.
h2
elements instead of h1
elements, it would be better.
because h1
has an important markup role and there should be just one of them in a page.Anyway, Your solution is awesome and deserves admiration. GOOD LUCK
@powreze
Submitted
Hi there! I'm Aulia π this is my solution for Order Summary Card.
Any feedback would be really appreciated.
Thank you πβ
@reza-sjdn
Posted
Hey @powreze,
I looked at your solution's code and figured out it's really perfect. You're great.
But maybe I could give you some small advises.
annual plan
and $59.99/year
it would've been better. additionally, if you set line-height: 1.5;
for content paragraph, it would look neater.width: 100%;
use width: 85%;
. This way you don't need to decrease padding for smaller medias and preventing overflow of price box content!Anyway I'd love your code! GOOD LOCK!
Marked as helpful
@amaar09
Submitted
Re-submitting after implementing the community feedback {@helenclx and @Lo-Deck}
@reza-sjdn
Posted
You've done this challenge well but you didn't consider some details.
border-radius
of sub-boxes of summary from 5px to 10px.hover
effect on continue button and its original background-color
is dark blue not black.I hope these will help you. GOOD LUCK.
Marked as helpful