Skip to content
OverviewSolutions
3
Comments
3
rapadev1
@rapadev1

All comments

  • rapadev1•50
    @rapadev1Posted 5 months ago

    Html: If there is a section that looks like a list such as a list of links, usually an unordered list is used

    Design: It's almost identical, very good

    1
  • rapadev1•50
    @rapadev1Posted 5 months ago

    For me it looks very good, I like that it used variables for colors, very well structured html

    0
  • Kla Marius•40
    @SmatsherSubmitted 5 months ago
    What are you most proud of, and what would you do differently next time?

    I did it in a day so I'm proud of myself for not putting it off.

    What challenges did you encounter, and how did you overcome them?

    I wasn't finding the color used for the body's background. I used a color extractor and then saw all the colors needed for the challenge in the styles-guide.md file.

    What specific areas of your project would you like help with?

    I would like some help with the semantic HTML. I wanna know if I'm using the right HTML tags for this challenge. I would like some feedback on my styling way. I wanna know if there is something I did wrong.

    Qr Code Component

    1
    rapadev1•50
    @rapadev1Posted 5 months ago

    It's great that you managed to make the card look almost identical to the given one, but it would be preferable not to write CSS in the index.html file. Also, I noticed that you used a ul tag (unordered list) for this card.

    I would have structured the card differently. For example, I would use a parent div (class="container") in which I would place two other divs: one for the image and another for the text.

    For the bold text, I would use the h1 tag.

    Marked as helpful
    0