Skip to content
Submitted 5 months ago

Qr Code Component

Kla Marius•40
@Smatsher
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I did it in a day so I'm proud of myself for not putting it off.

What challenges did you encounter, and how did you overcome them?

I wasn't finding the color used for the body's background. I used a color extractor and then saw all the colors needed for the challenge in the styles-guide.md file.

What specific areas of your project would you like help with?

I would like some help with the semantic HTML. I wanna know if I'm using the right HTML tags for this challenge. I would like some feedback on my styling way. I wanna know if there is something I did wrong.

Community feedback

  • rapadev1•50
    @rapadev1Posted 5 months ago

    It's great that you managed to make the card look almost identical to the given one, but it would be preferable not to write CSS in the index.html file. Also, I noticed that you used a ul tag (unordered list) for this card.

    I would have structured the card differently. For example, I would use a parent div (class="container") in which I would place two other divs: one for the image and another for the text.

    For the bold text, I would use the h1 tag.

    Marked as helpful
    0
    Kla Marius•40
    @SmatsherPosted 5 months ago

    @rapadev1 doing like you said was my first thought but doing it with an unordered list was another option so I decided to see if I can manage to do it that way. Thank you for you feedback. I appreciate

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord