Skip to content
OverviewSolutions
6
Comments
4
ramez bakeer
@ramezbakeer

All comments

  • oaved•90
    @oavedSubmitted 4 months ago
    What are you most proud of, and what would you do differently next time?

    I did good on the accessabilitiy on my table I think. I also think I structured my CSS well.

    What challenges did you encounter, and how did you overcome them?

    The bullets in the ul was kinda hard to position right. Both to get them aligned with the middle of the textbox even if the text started wrapping and to get the spacing right.

    What specific areas of your project would you like help with?

    Im working on my CSS structuring and HTML accessibility so help with those would be great although any constructive criticism is appreciated.

    A recipe page according to design

    1
    ramez bakeer•120
    @ramezbakeerPosted 4 months ago

    Nice work

    0
  • ramez bakeer•120
    @ramezbakeerPosted 4 months ago

    Good job, Its amazing to finish this challenge

    I have just one comment on your work

    There a scroll up and down and also left and right you can adjust this, that's all good work

    Marked as helpful
    0
  • ramez bakeer•120
    @ramezbakeerPosted 4 months ago

    **Nice work, it's great to finish this challenge **

    you can enhance your solution a little bit:

    1-use semantic HTML it's a best practice and improve accessibility that enable access for people with disabilities

    2-The layout is not responsive for different screen sizes so you can adapt this by using different techniques this resource can help you responsive design

    3-you made the h3 element color yellow you should make it yellow only when the user hover on it so you can use hover Pseudo-class for more clickhere

    0
  • ramez bakeer•120
    @ramezbakeerPosted 4 months ago

    ** Hello there, good job to complete the challenge.**

    I have some suggestions about your code that might interest you.

    1.You wrap the img element inside the anchor element and this is not required because it is a QR code and not a link in line 57 in the index.html file

    <a href="https://www.frontendmentor.io/" target="_blank">
        <img src="images/image-qr-code.png" width="100%">
 </a>

    2.You should use semantic HTML you can change the first div element with attribution class to a main landmark <main> with the same class to use the same style

    Marked as helpful
    0