Design comparison
SolutionDesign
Community feedback
- @ramezbakeerPosted 4 months ago
** Hello there, good job to complete the challenge.**
I have some suggestions about your code that might interest you.
1.You wrap the img element inside the anchor element and this is not required because it is a QR code and not a link in line 57 in the index.html file
<a href="https://www.frontendmentor.io/" target="_blank"> <img src="images/image-qr-code.png" width="100%"> </a>
2.You should use semantic HTML you can change the first div element with attribution class to a main landmark <main> with the same class to use the same style
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord