Skip to content
OverviewSolutions
33
Comments
4
qadzek
@qadzek

All comments

  • Tesla_Ambassador•3,000
    @tesla-ambassadorSubmitted 3 months ago
    What are you most proud of, and what would you do differently next time?

    I'm mostly proud of the fact that I got to learn how to use the react-hook-form and also completing this project while using TypeScript for the first time with Next.js.

    What challenges did you encounter, and how did you overcome them?

    I explained all these details in my README.md file

    What specific areas of your project would you like help with?

    Mainly accessibility and better coding practices when using Next.js/React.

    Mortgage Calculator using react-hook-form and TypeScript.

    2
    qadzek•540
    @qadzekPosted 3 months ago

    Well done, impressive work!

    TypeScript can be annoying indeed but it catches so many bugs. If you have trouble finding the TypeScript types, hovering over them in VS Code in the right place should reveal them.

    Congrats on implementing the comma separator, I skipped over that part.

    Possible improvements:

    • The interest rate input field should accept all floats, e.g. 4.9.
    • Don't use HTML like <br /> in Markdown.
    • Try using template literals (backticks) instead of spanValidClass and spanInvalidClass, to avoid duplication.
    • Intl.NumberFormat might be helpful.
    • Clicking on the far end of the box containing the radio button should work.
    Marked as helpful
    0
  • 👾 Ekaterine Mitagvaria 👾•7,600
    @catherineisonlineSubmitted over 2 years ago

    Hello, Frontend Mentor community! This is my solution to the REST Countries API with a color theme switcher.

    I appreciate all the feedback you left that helped me to improve this project. I fixed the issues I had previously and added new features per your recommendation.

    I have done this project a while ago however if you are here and have any feedback, tips, or ideas to share, I will be more than glad to hear them out!

    Thanks

    REST Countries API with color theme switcher

    13
    qadzek•540
    @qadzekPosted 10 months ago

    Nice work. I like how you have implemented the "Filter by Region" menu.

    A couple of small remarks:

    • I can confirm the bug described by @Javieer57.
    • The use of any in TS is discouraged.
    • There are tools online to automatically convert a JSON response to TS types: https://app.quicktype.io
    • I don't think there is a need for separate FilteredCountries and AllCountries components.
    • A single API call should suffice.
    0
  • Creedyfish•80
    @CreedyfishSubmitted 10 months ago

    The code is scuffed because it took me about 2 days to do step 3 with the checkboxes. it would have been fine if I only took the names of the checkboxes, but I also had to consider the prices of each box based on the choice in step2 so that means I have to create an array of objects and unfortunately. inputs cannot set objects as their value. Unless I am wrong, please do provide some info on how to do that. I have been at this for at least 2 weeks, so this challenge really beat the hell out of me. sorry for the language.

    I would really like to know If I could have solved most of my problems in a more efficient and less "brute force" way of coding especially in step 3 where I brute forced the checkboxes with its functions. am I using react-hook-form correctly? what should I learn more about when it comes to that?

    Multi-Step-Form using react-hook-form and Zod validation.

    1
    qadzek•540
    @qadzekPosted 10 months ago

    Take a look at this solution.

    Marked as helpful
    1
  • qadzek•540
    @qadzekPosted 12 months ago

    Looking good! I like the animation. Just make sure the design is responsive at every size, e.g. at 600px wide a lot of space is wasted.

    Marked as helpful
    0