Mortgage Calculator using react-hook-form and TypeScript.

Community feedback

• 

  qadzek•540

  @qadzekPosted 2 months ago

  Well done, impressive work!

  TypeScript can be annoying indeed but it catches so many bugs. If you have trouble finding the TypeScript types, hovering over them in VS Code in the right place should reveal them.

  Congrats on implementing the comma separator, I skipped over that part.

  Possible improvements:

  • The interest rate input field should accept all floats, e.g. 4.9.
  • Don't use HTML like <br /> in Markdown.
  • Try using template literals (backticks) instead of spanValidClass and spanInvalidClass, to avoid duplication.
  • Intl.NumberFormat might be helpful.
  • Clicking on the far end of the box containing the radio button should work.

  Marked as helpful

  0

  ---

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted 2 months ago

  @qadzek Thank you for your feedback! It's very much appreciated. I'm already working on another challenge and I'll be sure to apply what you've mentioned. I tried Intl.NumberFormat but I wanted to play around with regex. I do hover over functions and variables in VS Code... It's how I've been learning a lot more about TypeScript, it's very helpful. Thanks for taking the time to look at my code and helping me out... I'll be sure to implement this advice in my next challenge. Happy coding!

  0

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted 2 months ago

  @qadzek I tried adding 4.9 on the interest rate input field and it worked on my end... Does it show an error message on yours?

  0

  

  qadzek•540

  @qadzekPosted 2 months ago

  @tesla-ambassador

  I also learned that event handlers are of type React.ChangeEvent<HTMLInputElement> 
  

  To find out this type, inline the callback function (e.g. <input onChange={ ev => ... }>) and hover over ev.

  I tried adding 4.9 on the interest rate input field and it worked on my end... Does it show an error message on yours?
  

  Not sure what is going on. Sometimes it works without issues, sometimes I get Please select a valid value. The two nearest valid values are ....

  1
• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted about 2 months ago

  Broooooo

  I've just seen this!!

  Nice work dude! 😎 Your solution looks great and I loved reading your README 😂 You put a lot of thought into this and that's how you learn the most!

  Keep on grinding my guy and happy coding!! 😁

  EDIT: I'm touching grass these days... whenever I can 😜

  1

  ---

  

  Tesla_Ambassador•3,000

  @tesla-ambassadorPosted about 1 month ago

  @ApplePieGiraffe Thank you bruvvv! I'm working on something bigger with the interactive comment section. I'll be sure to let you know when it's done 😉

  PS: Touching grass is important for a jedi to become one with the code!

  1