@kayan2004Submitted 4 months ago
P
Prem Kumar
@prem-kumartAll comments
- @brainkaSubmitted 5 months agoWhat are you most proud of, and what would you do differently next time?
.
What challenges did you encounter, and how did you overcome them?.
What specific areas of your project would you like help with?.
- @jamesbrown173Submitted 4 months agoWhat are you most proud of, and what would you do differently next time?
This was defiantly my most challenging project to date, just because of the JS section. I'm not too familiar with JS and it took me a couple of tries to get the code correct. It took me 2 days.
I'm sure that the code could be improved in places, in particular the error handling.
What challenges did you encounter, and how did you overcome them?How to structure the JS code.
What specific areas of your project would you like help with?How to work better with handling errors in forms.
- @MoamenAbdelrahman7Submitted 4 months ago@prem-kumartPosted 4 months ago
- The solution looks great.
- The data renders perfectly.
1 - @Shakil-aSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
most proud:
- worked a lot more on javascript logic for the error state handling
- practised more with both my flex and grid skills
- managed to get most of the requirements done and close to design
what i would do differently next time:
- definitely spend more time on doing the javascript requirements before the css styling
- take all screen sizes into consideration when styling
- make a plan for the logic with pseudocode before starting to write the code
challenge 1 and solution: i went with mobile design first approach and at first failed to make it responsive for desktop version, how i solved this was through redoing the css and html structure and making a more responsive layout on mobile and expanding to larger screens
challenge 2 and solution: figuring out how to change the picture once we got to the desktop version without using a div and then just changing the background picture to the desktop one, how i solved this was through using the picture element and wrapping the default to the mobile img and then when the screen expands to 600px i have the source of the image of the desktop
What specific areas of your project would you like help with?specific problems i would be grateful for help in :
-
i still have problems with creating responsive layouts with a mobile first approach and taking the larger screens in consideration, some advice on how i can make it look good for the mobile, tablet and laptop screen sizes
-
any bad practises i implemented and some suggestion how to change that
-
if my javascript logic is okay or was there a better way to achieve this
- @JEWebDevSubmitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I´m proud that i feel a lot more comfortable doing the challenges
What challenges did you encounter, and how did you overcome them?styling the image was tricky, i had to try a lot of things but found out how with the
What specific areas of your project would you like help with?background-imagepropertyAny feedback is welcomed
@prem-kumartPosted 4 months ago- The solution looks great. Visually accurate to the design.
- I would suggest a few things. You seem to have not included the javascript part when clicking the the share button will show the social-links. Hope this is a deliberate decision.
- Just the basics of the javascript DOM manipulation would suffice to implement the functionality.
- I struggled with social-links bar that hovers over content in desktop version. Try using the CSS shapes site
https://css-tricks.com/the-shapes-of-css/this will. help you create such elements.and usage ofposition: absolute.
0 - @jamesbrown173Submitted 4 months agoWhat are you most proud of, and what would you do differently next time?
I want to practice user containers instead of fluid image sizes.
What specific areas of your project would you like help with?Sizing the hero image for different breakpoints. The images expand past the screen on the smaller versions, so I must set it to clip the overflow.
@prem-kumartPosted 4 months ago- Great work in reproducing the output as close as possible.
- Judging by the appearance of the solution few details are different from the solution. Would that be a personal design choice?
- if not. section identifying number 02 can be position using
relativeand hover over the footer. - As for the footer content using
flex-direction: rowwhen on desktop would do the trick. - Text in both the hero and mid-section seems to be larger than what the design requirement. Assign a max-width would make it more look like the design.
- Hope this helps.
0 - @Arnotts33Submitted 4 months agoWhat are you most proud of, and what would you do differently next time?
First time using grid! Very interesting compared to flexbox, even though a bit more complicated to apprehend for me :)
But I am really happy with the result. Did my research and managed to do something nice and responsive!
What challenges did you encounter, and how did you overcome them?The grid was quite a challenge for me as it was my first time using it.
Overcame it doing my research and found some good tutorials and videos to help.
I will play around with it even more to master as it is quite a powerful tool.
What specific areas of your project would you like help with?The real struggle was grid, so any comment or feedback welcome !
@prem-kumartPosted 4 months ago- The solution looks great!
- Judging from the styling css . You have used two media queries. Instead you can follow the mobile first design and add only one media query at the breaking point.
- Hope this helps.
0 - @FRYDPHROGSubmitted 5 months ago@prem-kumartPosted 5 months ago
- The solution looks great and code is clean and minimal.
0 - @KaEssamSubmitted 5 months ago@prem-kumartPosted 5 months ago
-The solution looks great!!!! -The codebase is very well structured with minimal code.
- I learned a lot looking at your codebase.
0 - @dawidPoznanskiSubmitted 5 months ago@prem-kumartPosted 5 months ago
- The solution looks good. Apart from little alignments.
Marked as helpful1 - @AnYa-gitSubmitted 5 months ago@prem-kumartPosted 5 months ago
- Instead of using a div. It would be more accessible to use semantic HTML.
- The code is well structured and readable.
0
