@musaabuu
Submitted
@patriciarrs
@musaabuu
Submitted
@patriciarrs
Posted
Greetings, musaabuu! 👋
Good effort on this challenge! 👍 The layout looks good on a range of screen sizes 🙂
I want to suggest taking another look at using semantic HTML on your site as it will also improve accessibility. Currently, you are using div
tags to wrap other elements, but other tags (for example, main
and nav
) are more suitable.
If you’d like to learn more about how to use semantic HTML on your site, check out this course from web.dev.
You may also consider using the :focus
pseudo-class so that, when a user navigates the page with the keyboard, he gets the same experience as if he were hovering the links.
I hope you find this helpful.
Happy coding!
Marked as helpful
@Arunstev
Submitted
@patriciarrs
Posted
Greetings, Arunstev! 👋
Good effort on this challenge! 👍 The layout looks good on a range of screen sizes 🙂
I want to suggest taking another look at using semantic HTML on your site as it will also improve accessibility. Currently, you are using div
tags to wrap other elements, but other tags (for example, main
and article
) are more suitable.
If you’d like to learn more about how to use semantic HTML on your site, check out this course from web.dev.
The solution has differences from the design. The most noticeable is the font family.
To correctly import the specified font family, you can go to the link you have in your @import
in the CSS file and then click "Get font" -> "Get embed code".
I hope you find this helpful.
Happy coding!
Marked as helpful
@mue864
Submitted
@patriciarrs
Posted
Greetings, Mutsah! 👋
Good effort on this challenge! 👍 The layout looks good on a range of screen sizes 🙂
I want to suggest taking another look at using semantic HTML on your site as it will also improve accessibility. Currently, you are using div
tags to wrap other elements, but other tags (for example, main
and footer
) are more suitable.
If you’d like to learn more about how to use semantic HTML on your site, check out this course from web.dev.
The solution has differences from the design. The two most noticeable are the font family and the card height.
head
tag:<link rel="preconnect" href="https://fonts.googleapis.com">
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin>
<link href="https://fonts.googleapis.com/css2?family=Outfit&display=swap" rel="stylesheet">
<link href="https://fonts.googleapis.com/css2?family=Outfit:wght@700&display=swap" rel="stylesheet">
To get the above, you can go to the link you have in your head
tag and then click "Get font" -> "Get embed code".
height
property to the card element to match the design.Edit: A better practice than adding a fixed height
to the card, is to have the correct spacing between elements by using the margin
and padding
properties as needed. To check the spacing between elements, in the Figma files select an element, press Alt
, and hover another element.
I hope you find this helpful.
Happy coding!
@slothPete7773
Submitted
How do I make mask color on the image? Also, in desktop view, when I add more padding, it takes up space in the left image, how should I solve that?
@patriciarrs
Posted
Hello there, I'm not sure if this is the best option but I used the CSS filter property to change the image color (https://developer.mozilla.org/en-US/docs/Web/CSS/filter). When I open the page it only shows the mobile design.