Used: Semantic HTML5 markup, CSS custom properties, media query, grid.

Community feedback

• 

  Patrícia Silva•105

  @patriciarrsPosted about 1 month ago

  Greetings, Ajinkya! 👋

  Good effort on this challenge! 👍 The layout looks good on a range of screen sizes 🙂

  I want to suggest taking another look at using semantic HTML on your site as it will also improve accessibility. Currently, you are using div tags to wrap other elements, but other tags (for example, main and section) are more suitable.

  If you’d like to learn more about using semantic HTML on your site, check out this course from web.dev.

  Regarding the heading elements (h1–h6), you can use multiple same-level elements (except for h1) as long as it makes sense. For example, instead of  h2, h3, and h4 for the various section titles, they can all be h2.

  If you’d like to learn more about using the heading elements on your site, check out this article from MDN.

  "Separation of concerns" is a good practice regarding HTML and CSS. Considering this, you could use HTML only for markup and have all the styles in the CSS file, instead of having inline styles in the HTML. This makes it easier to maintain and debug your page, as well as avoid CSS specificity-related issues.

  The solution has some differences from the design. One of the most noticeable is the font color. In the given style-guide.md file, there are various font colors used. Try out some of them to see what matches better (or if you have the Figma file, check there directly).

  I hope you find this helpful.

  Happy coding!

  0