@pankaj512Submitted almost 2 years ago
Pankaj Kumar
@pankaj512All comments
- @pankaj512Posted almost 2 years ago
Thanks for taking your time for this detailed review.
I'm just learning web development, so your feedback is 100% valued to me. Most of the time I get confused about which CSS units to use for what. If possible could you please provide some resources to learning about when to use what CSS units.
You said I should not set width to body, so where I should use provided width for desktop & mobile? On a container?
0 - @rockbell89Submitted almost 2 years ago@pankaj512Posted almost 2 years ago
Hi,
Cool build. Nice use of CSS, specially rem units. Like you used all html5 tags instead of div like me. Everything works fine but in mobile view you might want to add some margin on top and bottom.
Could you please provide some tutorial link to better understand when to use px, rem, em, % units.
Thanks
0