Brahimboutajbirine• 10
@Brahimboutajbirine
Submitted
Pablo Alvarado
@paalvarador
All comments
- Pablo Alvarado• 60
@paalvarador
Posted
Hi @Brahimboutajbirine
I review your code and I think this is clean and flexible. I think that you must to use main and footer tags for doing your app semantic HTML.
It is accessible and it does the goal,
Also, your code is well-structured, readable and reusable. And congrats for use a JavaScript library in the basic project.
Regards, Pablo
1 - Chris Sutcliffe• 10
@testpilotuk
Submitted
As a beginner I would like to see a more elegant and correct solution for positioning and creating the correct amount of white space. This was my first challenge and I must admit I enjoyed it.
Pablo Alvarado• 60@paalvarador
Posted
@testpilotuk
Hi Chris. The design it's ok
I recommend you use semantic HTML. For example, you can put all the main code into <main> tag and center the component on de screen. This is the first challenge and It's ok, but in the next challenges is important the use of layouts like flex or grid
When the project see on screen sizes with 375px you have to change the css to adjust it on mobile screens.
I think that your code its accessible
Enjoy your nexts challenges and happy code!
Marked as helpful
0
