Pablo Alvarado

Latest comments

• 

  Brahimboutajbirine•10

  @BrahimboutajbirineSubmitted almost 2 years ago

  

  Frontend Mentor - QR code component solution

  2

  71
  

  Pablo Alvarado•60

  @paalvaradorPosted almost 2 years ago

  Hi @Brahimboutajbirine

  I review your code and I think this is clean and flexible. I think that you must to use main and footer tags for doing your app semantic HTML.

  It is accessible and it does the goal,

  Also, your code is well-structured, readable and reusable. And congrats for use a JavaScript library in the basic project.

  Regards, Pablo

  1
• 

  Chris Sutcliffe•10

  @testpilotukSubmitted almost 2 years ago

  

  QR Code Component CSS Flexbox solution

  3

  90
  

  Pablo Alvarado•60

  @paalvaradorPosted almost 2 years ago

  @testpilotuk

  Hi Chris. The design it's ok

  I recommend you use semantic HTML. For example, you can put all the main code into <main> tag and center the component on de screen. This is the first challenge and It's ok, but in the next challenges is important the use of layouts like flex or grid

  When the project see on screen sizes with 375px you have to change the css to adjust it on mobile screens.

  I think that your code its accessible

  Enjoy your nexts challenges and happy code!

  Marked as helpful

  0