Skip to content
OverviewSolutions
2
Comments
2
Patrick OUAMBO
@ouambo-takouam

All comments

  • Patrick OUAMBO•40
    @ouambo-takouamPosted about 2 months ago

    In html code, it could be easier to have a main card bloc instead of having a container bloc being parent card bloc. This bloc seems too much <div class="learn"><p>Learning</p></div>. A simple span element with css code could be enough.

    For css code, media.css and style.css could be combined into a single css file.

    Marked as helpful
    1
  • Keiru Dev•20
    @Ashtreus1Submitted over 1 year ago
    What are you most proud of, and what would you do differently next time?

    Overall, I'm proud that I implement a solution to solve the challenge, even though this is just a basic one that any beginner can do. What would I do differently next time is that I can add interactivity and functionality here, like generating a QR Code based on the links inputted by the user.

    What challenges did you encounter, and how did you overcome them?

    One of the challenges I encountered is to imitate the final product without using any UI extension like Figma to help me navigating what style elements used in the challenge. Fortunately, I've overcome that by looking it closely, and try to imitate as I can.

    What specific areas of your project would you like help with?

    I don't think any areas that needed an assistance. I have pretty good background on it, that's why I implement the challenge well.

    QR Code Scanner with CSS Styling and positioning

    1
    Patrick OUAMBO•40
    @ouambo-takouamPosted about 2 months ago

    The html code is great. But instead of div with class card, a better choice could be main which is more semantic for me. Maybe the br inside the h1 isn't necessary for the design.

    In the css file, display: block for the card element isn't necessary cuz card is already a block element. And the font family could be declared once on body selector instead of setting it on both h1 and p. This is better for maintenance.

    0