I wanted to try making a toggle in JavaScript and it was awesome. Any feedback or suggestion on how I can improve would be highly appreciated. Happy Coding!
Thiago Moreira
@othiagomoreiraAll comments
- @K4UNGSubmitted over 2 years ago@othiagomoreiraPosted over 2 years ago
Good job! ✨
• When the mouse hovers over the button there is a small change in the layout, this is due to the fact that the border was added in the hover pseudo class, to fix it just add the border to the button element.
.btn, .btn-s { border: 2px solid white; } .btn-s:hover { background: transparent; color: var(--gradient-second); border-color: var(--gradient-second); }
Marked as helpful0 - @j-hutchisonSubmitted over 2 years ago
Any suggestions or possible improvements would be greatly appreciated!
@othiagomoreiraPosted over 2 years agoGood job! ✨
• You added border-radius to all elements, to fix this just remove the .section-column declaration and replicate the code below
.car-section{ border-radius: 1rem; overflow: hidden; }
• In the mobile version, the layout is "glued" to the top of the page, it would be interesting to add a padding
.body{ padding: 2rem 0; }
Marked as helpful0 - @simmax456Submitted almost 3 years ago
Any better ways to solve this challenge?
I had some difficulty aligning the card to the center of the page with flexbox; so, i went with this solution.
@othiagomoreiraPosted almost 3 years agoSo that you can center the card with flexbox it is necessary to declare a min-height: 100vh in the body
Marked as helpful0 - @catherineisonlineSubmitted almost 3 years ago
Hello, Frontend Mentor community! This is my solution to the Testimonials grid section.
I have read all the feedback on this project and improved my code. Due to the fact that I published this project very long ago, I am no longer updating it and changing its status to Public Archive on my Github.
You are free to download or use the code for reference in your projects, but I no longer update it or accept any feedback.
Thank you