Skip to content
OverviewSolutions
7
Comments
7
P
nrdygrnma
@nrdygrnma

All comments

  • nrdygrnma•160
    @nrdygrnmaPosted 12 days ago

    Really nice outcome! The only thing you may reconsider is the pretty dark box shadow. If you use some opacity on the color of it (e.g. 25%), it may look even nicer :)

    Marked as helpful
    1
  • nrdygrnma•160
    @nrdygrnmaPosted 12 days ago

    Your solution looks nice! A few observations from my side, if you allow me :)

    • The color of the titles look a bit dark - maybe a slightly lighter color, such as the smokey gray provided in the Figma file would look even better.
    • The box shadows could be a bit less dominating by using a lighter color (or use more opacity).
    Marked as helpful
    0
  • nrdygrnma•160
    @nrdygrnmaPosted 13 days ago

    Overall it looks great! A few observations if you may allow:

    • The card background color looks kind of off (blueish).
    • You could improve by reducing the line height of the title
    • The subtitle ("PERFUME") could be smaller to be less dominating.
    Marked as helpful
    0
  • nrdygrnma•160
    @nrdygrnmaPosted 13 days ago

    Your solution looks really good! Maybe just a few humble observations:

    • You can play with a bit more line-height for the paragraphs to give it more "air".
    • Your body background color seems different?
    0
  • nrdygrnma•160
    @nrdygrnmaPosted 14 days ago

    Great work! The solution is very close to the design and the proportions look very good.

    If I had any suggestions, then it would be that you could improve on your css and avoid repeating, e.g. in your "main-content" class you apply "text-align: center" several times. you could combine this in one block.

    You can also create custom properties for font sizes, weights and spacings, which could make the css even cleaner :)

    1
  • nrdygrnma•160
    @nrdygrnmaPosted 16 days ago

    Great implementation - it looks exactly the same! Thanks for letting me learn from you :)

    Marked as helpful
    1
  • nrdygrnma•160
    @nrdygrnmaPosted 16 days ago

    Unfortunately, I was not able to access your code on github.com - I would have loved to give my feedback :)

    0