moniquevnn• 20
@moniquevnn
Submitted
@nguernse
@moniquevnn
Submitted
@nguernse
Posted
Good job! Visually looks good. Some suggestions:
h1
tag. It's generally advised to keep it to one h1
per page. See here. Also, in the context of this project, using the h1
for the .TAG
and .post-copy
doesn't quite make sense here. Might opt for <span>
or <div>
for the .TAG
and <p>
for the .post-copy
.container-img
class could be refactored by moving the padding
into the .container
class. Then you could remove the div
which creates an unnecessary nesting.@ahmedraza032
Submitted
@nguernse
Posted
Looks good as is. Great job!
For future consideration, you might refactor the style.css
file to utilize css variables. This would benefit in the future, if the design system changes or you add more classes with similar attributes, allowing you to edit a single variable versus everywhere the same value is being used.
For example, working with the design system colors
:
:root {
--color-white: hsl(0, 0%, 100%);
--color-slate-300: hsl(212, 45%, 89%);
--color-slate-500: hsl(216, 15%, 48%);
--color-slate-900: hsl(218, 44%, 22%);
}
So then whenever you use the dark grey color you can do:
p {
color: var(--color-slate-900);
}
.text-content {
color: var(--color-slate-900);
}
Marked as helpful