QR component made using HTML and CSS

Community feedback

• 

  NG•40

  @nguernsePosted 4 months ago

  Looks good as is. Great job!

  For future consideration, you might refactor the style.css file to utilize css variables. This would benefit in the future, if the design system changes or you add more classes with similar attributes, allowing you to edit a single variable versus everywhere the same value is being used.

  For example, working with the design system colors:

  :root {
      --color-white: hsl(0, 0%, 100%);
      --color-slate-300: hsl(212, 45%, 89%);
      --color-slate-500: hsl(216, 15%, 48%);
      --color-slate-900: hsl(218, 44%, 22%);
  }
  

  So then whenever you use the dark grey color you can do:

  p {
      color: var(--color-slate-900);
  }
  
  .text-content {
      color: var(--color-slate-900);
  }
  

  Marked as helpful

  0

  ---

  

  Ahmed Raza•60

  @ahmedraza032Posted 4 months ago

  @nguernse Thank you so much for the advice. I'll definitely consider it in my future projects

  0