Skip to content
OverviewSolutions
5
Comments
3
Naresh
@nareshpoonia

All comments

  • Naresh•90
    @nareshpooniaSubmitted over 3 years ago

    I would love to get some feedback here.

    This is my third project. I have tried my best to match the design

    But I must have made some mistakes, must have done things that aren't standard practice.

    If you can point those out, It would be great help for me get better at CSS, Flexbox

    Thanks a lot.

    Mobile first using Flexbox

    2
    Naresh•90
    @nareshpooniaPosted over 3 years ago

    Hi Faris,

    Thank you so much for your feedback, I didn't know that we have to take care of the contrast too, that's why i didn't reply to your comment earlier.

    While researching for one more of my projects, i came to know about WCAG, that's when i understood your point.

    Just because of your comment, I had some hint about contrast.

    Thanks again for introducing me to a new concept.

    1
  • Naresh•90
    @nareshpooniaPosted over 3 years ago

    Hi Amin, In the solution, the social media icons are slightly different then they are in the design. Also in the design there is a circle around the social media icons. You can find similar icons on FontAwesome & add a circle around it to match the design. All the best.

    Marked as helpful
    0
  • Kartik Goel•10
    @kartikgoel130Submitted over 3 years ago

    Is my frontend is looking complicated in terms of code or its fine to understand for future changes?

    My First Challenge

    2
    Naresh•90
    @nareshpooniaPosted over 3 years ago

    Hi Kartik,

    Congratulation on your first project !!

    There are a few things that you can do in future projects. In a starter code there is README-template file, where in you can put in details like screenshots of your project, links to your solution URL and live site URL, approached you used to complete the project, What you learned etc. You can then delete the readme file and rename README-template file to readme.

    It's always a good practice to have a good Readme file, especially for more complex projects.

    All the best for your future projects.

    0