Skip to content
Submitted over 3 years ago

Mobile first using Flexbox

Naresh•90
@nareshpoonia
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Single price grid component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I would love to get some feedback here.

This is my third project. I have tried my best to match the design

But I must have made some mistakes, must have done things that aren't standard practice.

If you can point those out, It would be great help for me get better at CSS, Flexbox

Thanks a lot.

Community feedback

  • Naresh•90
    @nareshpooniaPosted over 3 years ago

    Hi Faris,

    Thank you so much for your feedback, I didn't know that we have to take care of the contrast too, that's why i didn't reply to your comment earlier.

    While researching for one more of my projects, i came to know about WCAG, that's when i understood your point.

    Just because of your comment, I had some hint about contrast.

    Thanks again for introducing me to a new concept.

    1
    Faris P•2,810
    @FarisPalayiPosted over 3 years ago

    @nareshpoonia Glad to know that it helped you in some way 🙂. Also, glad to know that you are reading WCAG guidelines. There's a free accessibility course from Google in Udacity. You can take that if you want to.

    0
  • Faris P•2,810
    @FarisPalayiPosted over 3 years ago

    The site looks good and responds well. The only thing to point out is about text contrast, for example in the button, the text contrast ratio is 1.51 which way less than recommended minimum 4.5:1 contrast ratio, because it'll be really hard for people with visual impairments to navigate through the site.

    That's all from me. Have fun coding ✨

    1

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord