All comments

• 

  Nikita•120

  @nyakitaSubmitted about 2 years ago

  Hello Guys,

  I re-submitted solution for this challenge, any advices for improvements more than welcome!

  

  Landing with HTML CSS and GRID

  1

  20
  

  Nour Al-Osman•60

  @nalosmanPosted about 2 years ago

  Hi Nikita, I'm looking at the code and live site, and first of all good job on doing it! I do have some pointers for improvement and future projects.

  1. Instead of using all <div> you can using html5 tags like <main> to wrap all the body code in, <header> to place the logo in which they gave as an svg image to use. (For structural and html outline you can use the h1 and use a .sr-only class to make it disappear off the page but still there if needed)

  2. For the register button and the social media icons, on hover you can do "cursor:pointer" in your css for clickable elements.

  I'm not familiar with grid, so can't help there but just from looking at it there is some issues with spacing and distances. Hope this helps and gives a starting point for revisions!!😊

  Cheers and good luck!!!✌️

  0