Design comparison
Solution retrospective
Hello Guys,
I re-submitted solution for this challenge, any advices for improvements more than welcome!
Community feedback
- @nalosmanPosted about 2 years ago
Hi Nikita, I'm looking at the code and live site, and first of all good job on doing it! I do have some pointers for improvement and future projects.
-
Instead of using all <div> you can using html5 tags like <main> to wrap all the body code in, <header> to place the logo in which they gave as an svg image to use. (For structural and html outline you can use the h1 and use a .sr-only class to make it disappear off the page but still there if needed)
-
For the register button and the social media icons, on hover you can do "cursor:pointer" in your css for clickable elements.
I'm not familiar with grid, so can't help there but just from looking at it there is some issues with spacing and distances. Hope this helps and gives a starting point for revisions!!😊
Cheers and good luck!!!✌️
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord