Hey!
4th challenge is complete!
I tried a different approach for this one and did a lot of experimentation with grid. I'm pretty sure the way I achieved my solution was pretty counter-intuitive so any feedback to make my solution better would be amazing!
Got it as close as I can but hopefully, my proportions aren't wrong lol
Best, Najib
Hey Grace! Thank you so much for your feedback :)
I'll be happy to clarify some of my thought process while doing it.
So for the pseudos, I honestly didn't have time to research that much about how to make the borders look like that. Tried using border-top but it looked ugly lol so I just tried to be creative.
Im having a hard time figuring out the best way to write css. When should I include the parents in the declaration (e.g .parent .child .nested) and when should it just be (.child). Very confused on this aspect!
With regards to why I used a lot of em's, it was because after watching a bunch of Kevin Powell videos he brings up that he only uses rem's for font-sizes, and em for everything else. Is this not best practice? Should I be using some px's here and there?
Also sorry for the code being a bit blocky and excessive. I just wanted to get as close to the design as possible. I noticed that when shifting from mobile to desktop, there are some changes in: spacing, font-sizing, etc. And that's what I wanted to change in the media queries as well.
Sorry I know these are a lot of questions!
Any and all help is appreciated :)
This is my solution to the 3-Column Preview Card. Feel free to give any suggestion or pointing out any mistakes I made.
Hey there!
It seems that you've submitted an empty repository accidentally!
I can only see the README.md file at the moment. Try pushing your code up to Github and then you can go ahead and click "Regenerate Screenshot" to get rid of that 404 :)
My first FM challenge!
Question: Is the way I used the :root variables in media queries to adjust font sizes a good solution? Ended up storing only the intro card font sizes and I'm not sure if I should've done that lol!
I know this challenge is on the simpler side, but I really want to establish my pure HTML & CSS before I move on to more complicated challenges!
P.S Congrats to Matt & the FM team for creating such an amazing platform!
For the line heights, I decided to divide the ones given in the sketch file by the font size for that element. That's what I understood from the MDN docs :S
Unfortunately they don't seem to be pixel perfect! Can anyone let me know what the best approach is to doing this?
Thanks guys!
My first FM challenge!
Question: Is the way I used the :root variables in media queries to adjust font sizes a good solution? Ended up storing only the intro card font sizes and I'm not sure if I should've done that lol!
I know this challenge is on the simpler side, but I really want to establish my pure HTML & CSS before I move on to more complicated challenges!
P.S Congrats to Matt & the FM team for creating such an amazing platform!
Hey Guys!!
I can't believe I missed the best feedback in the world yesterday lol (Sorry Vanza!!).
You guys are amazing. I updated my project and hopefully everything should be all good now :)
Please let me know if I missed anything!
Changes:
Thank you Vanza & Grace!! Najib
