@igorsantos-pSubmitted 10 months ago
Latest solutions
Creating basic card component using semantic HTML and CSS Grid
Submitted about 1 year ago-I used both footer element (as parent) and small element (as child) for the copyright text "Challenge by Frontend Mentor. Coded by Sitare." to keep it semantically correct HTML. But am I overkilling it, should I stick with only one of them?
Latest comments
- @goncho09Submitted 12 months ago@msa-sitarePosted 12 months ago
I'd recommend changing the image width from 60% to 100%, this way it lines up with the content nicely. Keep up the good work.
Marked as helpful0 - @auxano1003Submitted 12 months agoWhat are you most proud of, and what would you do differently next time?
I am excited i was able to do this simple project in the quickest time i could
What challenges did you encounter, and how did you overcome them?trying to understand how buttons are used alongside the margin property
@msa-sitarePosted 12 months agoYour layout is structurally sound, but it lacks attention to detail in terms of proportions and spacing. Consider refining the dimensions, padding, margin, and alignment to ensure consistency. Good work, and with a little fine-tuning, it'll be even better!
0 - @gabrieltrtlSubmitted about 1 year agoWhat are you most proud of, and what would you do differently next time?
For this and other challenges, I confess that I would have liked to have used SASS, even without needing it.
What challenges did you encounter, and how did you overcome them?I encountered difficulties with sizing this image, but I reached out to the FEM community for help and got the answers I was looking for.
What specific areas of your project would you like help with?I would like to receive a code review, to know if I'm on the right track, I don't feel confident in my code yet
@msa-sitarePosted about 1 year agoHey it's pretty good, you have very good attention to detail.
my only recommendation would be to change drop-shadow to make it like the exact design. Something like this:
@media (min-width: 650px) { main { max-width: 24rem; box-shadow: 8px 8px; } main:hover { box-shadow: 16px 16px; } }Right now it looks like the default state has 16px drop-shadow. Except for this nitpick, it's great.
0
