Submitted 6 months ago

Creating basic card component using semantic HTML and CSS Grid

msa-sitare• 70

@msa-sitare

Preview site(opens in new window)View code(opens in new window)

This is a solution for...

QR code component

HTML
CSS

1newbie

View challenge

Design comparison

SolutionDesign

Solution retrospective

What are you most proud of, and what would you do differently next time?

I've just started coding. I try my best to use semantically correct HTML elements. I haven't learned CSS Flexbox or Grid, so I plan to focus on them next. This is my first coding project ever without any hand-holding. Overall I'm happy with the result and the time I spend.

What challenges did you encounter, and how did you overcome them?

Centering the card was my biggest challenge. Now I do understand "center the div" jokes.

What specific areas of your project would you like help with?

-I used both footer element (as parent) and small element (as child) for the copyright text "Challenge by Frontend Mentor. Coded by Sitare." to keep it semantically correct HTML. But am I overkilling it, should I stick with only one of them?

Community feedback

Anyona Zaddock Ogada• 190

@zacc-anyona

Posted 6 months ago

Hello msa-sitare,

You done a great job in taking your time to finish this challenge. However there are a few areas you can improve on;

Use HTML landmarks. Starting now start using HTML5 landmarks as they contribute greatly to the accessibility of your website. Moreover, landmarks help search engines, screen readers and other developers know the flow of content on your web page. Instead of using <div class="content"></div you could have used <main class="content"></main>. There are also other landmark tags such as <footer></footer>. Refuse to suffer from a disease called 'Divitis', most young developers suffer from it. It is a pandemic! I myself used to suffer from it. :) Learn to use HTML landmarks here.

Other than that your work is excellent. I love it. You have potential, always stay hungry to learn more. If you find my comment useful don't forget to mark it as helpful and give me an upvote.

Marked as helpful

Please log in to post a comment

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord