Skip to content
OverviewSolutions
8
Comments
4
Kevin Mason
@mrfinesse47

All comments

  • daniel asakpa•100
    @danielasakpaSubmitted over 2 years ago

    I'm not sure if the way I created the routing was correct, and I'm having trouble making the dark/light mode future because when react renders and I toggle it, the light mode works, but some of the dark mode components remain white, could someone maybe explain?

    REST Countries API with color theme switcher

    1
    Kevin Mason•280
    @mrfinesse47Posted over 2 years ago

    Hi there, the app looks good. It looks exactly as it should. Just some functionality is not working such as the light mode/ dark mode picker. Also, some of the countries wont come up when clicked on. Also another thing i noticed is when i press enter on the search the page refreshes, in a react app this should not happen, you probably missed preventDefault() on the form submit.

    Marked as helpful
    1
  • Travolgi 🍕•31,400
    @denieldenSubmitted almost 3 years ago

    Hi there :)

    I had a lot of fun in this challenge and had a good opportunity to learn how to use Router v6 and Styled Components for the first time.

    Also I practiced a lot with React custom hooks, initially I had some problems in the details page because React didn't update the page content because I rightly didn't set the listening on the parameter that changed.

    Also I added some additional features:

    • See current country weather data on detail page through other API
    • See the Map of the country on the details page
    • Button scroll to top after the scrool
    • Button for query reset when typing on the search input
    • Error page with animated svg when no results found
    • LocalStorage save of the set light or dark mode theme

    But...

    • Despite my extensive research I still have to figure out how I can create a preload at render time while react builds the page so that the "hops" due to reset.css are not seen as soon as the app is opened.
    • I also want to understand how to show an upload on the single image as it is uploaded.

    Thank you for taking the time to check out my project! And Happy coding ;)

    React REST Countries & Weather API with color theme switcher

    7
    Kevin Mason•280
    @mrfinesse47Posted over 2 years ago

    hello,

    good job on this project especially with the maps and weather additions. one thing i noticed is that some of the buttons such as "back" don't change the cursor to pointer. The Neighbour countries buttons only work when you click on the text but not anywhere else on the button. I also think the drop down items can use some more styling to be more inline with the design documentation. I really liked the loading transition, and custom slider. You have lots of neat extra additions.

    Marked as helpful
    1
  • Kevin Mason•280
    @mrfinesse47Posted over 2 years ago

    .one thing i noticed if if you delete all the numbers you get a NaN on the calc display, only when the number showing is negative. Otherwise the app looks awesome. Good job..............................................................................................................................................................................................................................................................................................................................................................................................................................................

    Marked as helpful
    0
  • Kevin Mason•280
    @mrfinesse47Posted almost 3 years ago

    looks very good, pretty much identical to the original.

    1