Mitha B
@mittens67All comments
- @mrprogrammer1-2Submitted 24 days ago@mittens67Posted about 16 hours ago
Good job! Slightly larger than the original, but the styles look accurate.
Marked as helpful0 - @kareemsakrSubmitted 2 days agoWhat are you most proud of, and what would you do differently next time?
Did it in less than an hour
What challenges did you encounter, and how did you overcome them?setting the color on the top of the cards
What specific areas of your project would you like help with?The quality of my css and how I implemented the responsiveness of my page
- @samotazkySubmitted over 1 year ago
- @carolsemeaoSubmitted 9 months ago@mittens67Posted 24 days ago
Nice Work! The only difference i see is the missing background color for the "Preparation Time" card, but other than that it looks good to me.
Keep it up!
0 - @CamiloBeltran24Submitted 26 days ago
- @jrosellrSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
I'm proud of the way I used Sass to write my media queries.
I'd probably spend less time thinking around making complex mixins for typography and couple the style to the final class. I tend to start with a ream of utility classes only to throw them away later.
What challenges did you encounter, and how did you overcome them?I didn't find any particular challenge. If I were to mention something, that would be the media queries and CSS reset.
What specific areas of your project would you like help with?I'd like feedback about accessibility and Sass.
I'm afraid I could improve my use of mixins/functions to repeat less code.
@mittens67Posted 26 days agoNice solution! I'm a beginner with SASS so I'm afraid i don't have many helpful review comments there. On the contrary I got to learn a few things from your code myself! The HTML looks semantically good as well.
0 - @AlisCodeSpaceSubmitted about 1 month ago@mittens67Posted about 1 month ago
- The content can be wrapped in a semantic HTML element like <main> or <section>.
Ex:
<main class="main--page"> <div class="qr--cont"> ... </div> </main>This will enhance the site's accessibility by clearly defining the primary content area.
- The alt text is a bit generic. Making it more descriptive can help users relying on screen readers. Ex: alt="Scan this QR code to visit Frontend Mentor's website"
0