Skip to content
OverviewSolutions
2
Comments
2
mitch-webdev
@mitch-webdev

All comments

  • mitch-webdev•60
    @mitch-webdevPosted almost 3 years ago

    Hey Dejan,

    Good work in my opinion!

    My suggestion would be:

    • You could make sure the text and the image are using the exact same space by specifying the amount of grow both elements have. Use flex:1 for both elements so they use the same amount of space. :)

    I am a beginner so I cannot guarantee it is the best solution but you could look into it ;)

    Keep doing great work!

    Mitch

    Marked as helpful
    1
  • mitch-webdev•60
    @mitch-webdevPosted about 3 years ago

    Hello Martin!

    Awesome job on finising this challenge. I also just finished it :) Well done on using proper alt-text in your HTML elements ! I also like that you labelled your code with comments so it is pretty easy to read. Regarding your question, I would use flexbox.

    Overall I think your design looks really good but those are my suggestions (I am also a newbie so my suggestions might not be the right ones. Please keep that in mind) :

    • The desktop background image could take the entire space by specifying the backgroud-size of 100%
    • The hover effects could include a transition delay so that hover is not so abrupt. Look at the following to see how to do that: https://www.w3schools.com/css/css3_transitions.asp
    • Your card element could take a bit more space in terms of width and height (on desktop version)

    Keep up the good work dude! Feel free to also leave a feedback on mine so we can help each other out!

    Marked as helpful
    1