Basics of colors, positioning elements

Community feedback

• 

  mitch-webdev•60

  @mitch-webdevPosted about 3 years ago

  Hello Martin!

  Awesome job on finising this challenge. I also just finished it :) Well done on using proper alt-text in your HTML elements ! I also like that you labelled your code with comments so it is pretty easy to read. Regarding your question, I would use flexbox.

  Overall I think your design looks really good but those are my suggestions (I am also a newbie so my suggestions might not be the right ones. Please keep that in mind) :

  • The desktop background image could take the entire space by specifying the backgroud-size of 100%
  • The hover effects could include a transition delay so that hover is not so abrupt. Look at the following to see how to do that: https://www.w3schools.com/css/css3_transitions.asp
  • Your card element could take a bit more space in terms of width and height (on desktop version)

  Keep up the good work dude! Feel free to also leave a feedback on mine so we can help each other out!

  Marked as helpful

  1

  ---

  

  Martin Eliáš•890

  @martinelias1312Posted about 3 years ago

  @mitch-webdev Hello Mitch,

  thank you for your response and some encouraging words that i am doing something good. :) I appreciate your suggestions and i´ll implement them on my future work.

  Thanks, i´ll look ak your solutions and leave a feedback!

  1
• 

  raouf-rs•20

  @raouf-rsPosted about 3 years ago

  Use display flex ,align-items(vertical) , justify-content(horizantal)

  Marked as helpful

  1

  ---

  

  Martin Eliáš•890

  @martinelias1312Posted about 3 years ago

  @raouf-rs Thanks, i will definitely implement your suggestions.

  0