Skip to content
OverviewSolutions
7
Comments
2
Michael Onyeabo
@michyking

All comments

  • Michael Onyeabo•200
    @michykingPosted about 1 year ago

    Hi Mariya 👋

    Congratulations on finishing the project, it looks pretty good!🎉

    BUT❗

    I have a few observations.

    The closing HTML tag in your HTML code is missing a ">" symbol. It should be </html> instead of </html. In your CSS file, it's a good practice to define your custom styles before the media queries. This makes the code easier to read and maintain. Also, in your CSS, when specifying a font family, use single or double quotes around the font name. For example, use font-family: "Roboto", sans-serif;. In the media queries, you've specified font-size: 3rem; font-family: 700;, but the correct way to define a font-weight is font-weight: 700;.

    Marked as helpful
    1
  • Patricia•110
    @PatixiSubmitted about 1 year ago

    hello!!! I have some questions about css in this proyect;

    1. I choose to put @font-face to insert the different fonts , is this better than with a link on the html? which one is faster or what do you recommend.?
    2. Using css to change de style when you put a incorrect value on the inputs i used :invalid for inputs and for the text, but wasn´t working for the label to change the color, so i have to use :has(input:invalid) . why was this happening? anyone can tell me?

    About javascript is there any other functions or methods more apropiated?

    thanks a lot for reading!!!!!

    Age calculator app

    1
    Michael Onyeabo•200
    @michykingPosted about 1 year ago

    When it comes to adding fonts to your webpages, I think it boils down to individual preference. For me, I love adding the link to the font in my HTML as I dimmed it faster and easier to use in my own perpective.

    1