Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Newsletter sign-up form with success message

MARIYA 20

@Mariya-9

Desktop design screenshot for the Newsletter sign-up form with success message coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


. Image Responsive

Community feedback

@michyking

Posted

Hi Mariya 👋

Congratulations on finishing the project, it looks pretty good!🎉

BUT❗

I have a few observations.

The closing HTML tag in your HTML code is missing a ">" symbol. It should be </html> instead of </html. In your CSS file, it's a good practice to define your custom styles before the media queries. This makes the code easier to read and maintain. Also, in your CSS, when specifying a font family, use single or double quotes around the font name. For example, use font-family: "Roboto", sans-serif;. In the media queries, you've specified font-size: 3rem; font-family: 700;, but the correct way to define a font-weight is font-weight: 700;.

Marked as helpful

1

MARIYA 20

@Mariya-9

Posted

@michyking

Hi Michael,

Thank you so much for your comment.

I appreciate that.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord