All comments

• 

  alexcom23• 10

  @alexcom23

  Submitted over 1 year ago

  Obviously, this was a fairly easy coding task but I would like to improve on anything if necessary. I wish to be exceptional at frontend development so any suggestions on best coding practices that I should implement or any other improvements would be greatly appreciated!

  

  QR code example w/ adaptive image and text sizing

  2

  40

  

  Mohammad Hossein Amirpanahi• 390

  @mhap75

  Posted over 1 year ago

  Hello alexcom23! Congratulations on entering the front-end field! Some suggestions for making your solutions better:

  • You don't have to upload /design and README-template.md to your repository.
  • Make your code more accessible by using semantic HTML.
  • For parent elements like body it's better to use display: grid; which gives more control over its child elements.
  • Keep in mind there is a principle called DRY. Its for all types of coding.

  Happy coding! ( ͡ᵔ ͜ʖ ͡ᵔ )

  Marked as helpful

  1