@Mr-jaw
Posted
Hey there 👋
well done on completing the challenge
HTML 📄
- replace
<div class="qr-component">
with themain
tag, And<div class="attribution">
with afooter
tag to fix accessibility issues.
CSS 🎨
- give the image a
max-width
of 90% instead of justwidth
img {
max-width: 95%;
}
-
Also Always give meaningful and humanly understandable descriptive text about what the image is about in the
alt
attribute. it also will reduce some accessibility issues -
rather than using
px
which is an absolute unit. Useem
orrem
for margins, paddings, width, and height. most probablyrem
for font sizes to make it more responsive
Also, you had a best practice of using CSS custom properties which is great.
I hope this was useful 😊
KEEP IT UP
Marked as helpful