@theJRodrigues
Submitted
Michelle Chong
@mdchong
All comments
- Michelle Chong• 60
@mdchong
Posted
Hey Jean! Nice job you've done here! One of the things I noticed and recommend is to always place contents inside the <header><nav><main><aside><footer>, rather than using <containers> or any other elements outside of it!
Think or view HTML like a little story plot! As we can see, our recipe page includes only the main part of the story. So, we can easily assume that all contents should fall under the <main> tag.
Which also goes the same for the .attribution. I recommend placing this inside of the <footer> tag, which contains the contents that should go after the story. Think of the footer as the ending credit of the movie!
0 What are you most proud of, and what would you do differently next time?
I did this project using CSS presets for the first time and am really happy with how it went. I'll definitely be using them for every project going forward. I also implemented media queries for the first time and it was much easier than I thought it was going to be. New hover interactions were also used. I'm very happy with how this turned out.
What challenges did you encounter, and how did you overcome them?
Never doing CSS Presets or Media Queries too some time to figure out but now that I know them, things will hopefully get much faster and more streamlined in the future.
What specific areas of your project would you like help with?
I think everything went ok and is looking good but if you see anything I missed or ways I can improve my code, please let me know. Thanks.
Michelle Chong• 60@mdchong
Posted
Your solution looks quite similar to the design provided! As I lack knowledge of coding, I am not sure if I am in the place to give a helpful feedback. I am glad you used CSS presets as they are really helpful! I've recently received a feedback that there are many resets out there and it will be really helpful to understand why they were written that way.
Marked as helpful
0- GJHUD• 30
@GJHUD
Submitted
Michelle Chong• 60@mdchong
Posted
Wow, the solution is very similar to the design provided! As a beginner, I can't really provide good feedback regarding your code, but I really love how similar your solution came out. But one thing I noticed is that when you minimize the page to a mobile resolution, it's not as responsive as it should be, and the contents are overflowing. Looking through your CSS file, you used a px value for your width!
0 - duchi8386• 30
@duchi8386
Submitted
Michelle Chong• 60@mdchong
Posted
The solution differs from the design, and I believe changes should be made! The color used is different from the design, the border-radius seems weak for the card, I don't see any on the QR image, the font seems comparably small and unreadable, the layout seems smaller than the desired design, unnecessary blue border around the card, the color of the font is different as well! There isn't even box-shadow beneath the card.
Don't worry, you can do this! I recommend going through this challenge again before moving on!
0
