Skip to content
OverviewSolutions
10
Comments
4
Moises Castillo
@mcasti19

All comments

  • Moises Castillo•220
    @mcasti19Posted 4 months ago

    Hello, greetings, I have seen your project, I am a beginner, I still need to learn a lot, but I have seen your code and it fascinated me, extremely organized, clean and easy to read, I congratulate you. I will write down some tips that I could see in the form of your code, keep it up!

    Marked as helpful
    1
  • Moises Castillo•220
    @mcasti19Posted about 1 year ago

    Hi, if you want center the content, you can try this

    body { height: 100vh; display: flex; justify-content: center; align-items: center; }

    You can reduce the size of the button a little and I think you didn't work on the design for mobile, right?

    and finally remember the background-color of the body

    You are doing a good job, practice makes master :) don't stop practicing

    0
  • Gerardo Garcia•170
    @GGSWEngineerSubmitted about 1 year ago

    Hello everyone!

    Appreciate you all looking at my solution for my product preview card component.

    A few questions...

    Ideally, you would want to start building out this project starting out with the mobile version first, correct? I figured this out after finishing the desktop version but can anyone help explain why?

    I looked at the style guide and README files to find the colors of the project but it didn't match to the actual picture given to me by frontendmentor. A bit unsure if I mistyped the color or not. Did anyone else experience this issue?

    As my screen gets smaller, my container and the content inside it don't change much in size and only adjust drastically when it hits the max-width media 600px. Is this standard or should my project be more responsive?

    Finally, when we add the media queries is it usual to add a lot more code there, or is it usually just a few things? I feel like I added too many selectors and properties there, but would love to hear the communities input.

    Thank you for your time,

    Gerardo Garcia

    Product Preview Card Component

    3
    Moises Castillo•220
    @mcasti19Posted about 1 year ago

    Hello GGSWEngineer, how are you? I am a beginner, I think your work is very good, the more you practice, the better the skills.

    Since 2015, Google had announced that the majority of traffic and searches on the internet were being done from mobile devices, which is why the so-called "Mobile First" approach was born, which is why it is currently customary to first design and develop sites for mobile and then the other sizes. for other devices, I usually use 3, mobile, tablet and desktop.

    As for the colors, I have experienced some slight differences, but I use a chrome extension called "colorzilla" and it helps me have the colors much more similar when it is difficult for me to see them the same. In the case of the background the color was "- Cream: hsl(30, 38%, 92%)"

    As for the mediaQueries, the properties that you must place are those that will really affect the design since many are already inherited from the 1st design, therefore there is no need to repeat them if they are not going to affect the new size

    I hope it is useful to you, you can also take a look at my work and give me some suggestions to improve :) happy day

    Marked as helpful
    1
  • Moises Castillo•220
    @mcasti19Posted about 1 year ago

    Hello my friend, your result looks great, you could add a line-height: 1.5; to the paragraph and add the active state with hover on the button, I did it this way .button:hover { background-color: #1A4031;}

    It should be noted that I am also a beginner :) but I liked your result more than mine :)

    Marked as helpful
    1