Skip to content
OverviewSolutions
5
Comments
2
Matěj Kubíček
@matejkubicek

All comments

  • dotrider•70
    @dotriderSubmitted almost 5 years ago

    Hello all, I feel like my CSS is too long for this project, any advice I can clean it up more? Also, how can I center "per month" next to the price? I will appreciate any feedback.

    Created with CSS Grid - Mobile-first Design

    2
    Matěj Kubíček•130
    @matejkubicekPosted almost 5 years ago

    Hi, nice work, your css is not too long. For vertical align "per month" try vertical-align: middle, in your case apply on both spans.

    1
  • Matěj Kubíček•130
    @matejkubicekSubmitted almost 5 years ago

    Please leave me a feedback about my code and used workflow. Thx

    After reading the report I have two questions:

    1. Element section must have a heading? Why?
    2. Element a must contain word (or elements span, p, img...)? Solution with element svg included in a element is big problem?

    Thx for any commentary.

    btw. I had a problem with | character in font link. This character separates two different font-face. | can be replaced with%7C and problem is solved.

    Huddle - HTML, CSS, SCSS, BEM, NPM scripts, SVG sprite, CSS grid

    1
    Matěj Kubíček•130
    @matejkubicekPosted almost 5 years ago

    point 1. repaired - I added role="img" atribut to svg tag and to the svg tag new tag title with short description.

    Article about SVG ACCESSIBILITY on css-tricks.com

    1