Submitted almost 5 years ago
Huddle - HTML, CSS, SCSS, BEM, NPM scripts, SVG sprite, CSS grid
@matejkubicek
Design comparison
SolutionDesign
Solution retrospective
Please leave me a feedback about my code and used workflow. Thx
After reading the report I have two questions:
- Element
section
must have a heading? Why? - Element
a
must contain word (or elementsspan
,p
,img
...)? Solution with elementsvg
included ina
element is big problem?
Thx for any commentary.
btw. I had a problem with |
character in font link. This character separates two different font-face. |
can be replaced with%7C
and problem is solved.
Community feedback
- @matejkubicekPosted almost 5 years ago
point 1. repaired - I added
role="img"
atribut to svg tag and to the svg tag new tagtitle
with short description.Article about SVG ACCESSIBILITY on css-tricks.com
1@mattstuddertPosted almost 5 years agoGreat work resolving these issues by yourself Matěj! Your solution looks really good too 👍
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord