Skip to content
OverviewSolutions
9
Comments
4
Matheus Oliveira
@matebeing

All comments

  • Matheus Oliveira•160
    @matebeingPosted over 2 years ago

    Good job, Danielle Domingo!

    It depends on the circumstances, I'd rather to use rem when I want to my elements to modifies its attributes relative on the parent values, because rem is an relative CSS - it prevents the commons classic scaling problems. I would use pix when I want to use a fix value.

    I saw your HTML has accessibility issues, try to check out them on the report page. It is really necessary to keep accessibility.

    Good luck :)

    Marked as helpful
    1
  • BelalBahaa•40
    @belalbahaa1Submitted over 2 years ago

    Please feel free to provide me any suggestions; it will be really beneficial.

    Order summary card

    1
    Matheus Oliveira•160
    @matebeingPosted over 2 years ago

    Great job finishing this challenge , Bela!🎉🎉

    I have some tips for you

    • Write an alternative text for the image, this way you can provide accessibility to the ones who has disabilities.

    • Try to learn about CSS units and focus on relative units - so your components will look more fluid and responsive

    • Learn about flex box You can position your elements in a better way! So, instead of using position: relative and position: absolute

    Try removing transform, position top, left from your body, and main element and inside body insert:

    display: flex;
align-items: center;
justify-content: center;
flex-direction: column;
height: 100vh;
width: 100%;

    Some other elements may break, but you can fix them easily removing the position or the respective issue.

    You can check my solution visiting my profile, so you can see how I did and check if something could help you.

    Marked as helpful
    0
  • sto•60
    @Sohila-SamirSubmitted over 2 years ago

    I'm more of a backender so I'm not so good with CSS yet. I'd appreciate if you can review my style.css file and give feedback on the code and if there's anything I can improve or change. thanks in advance :)

    just used: CSS3 and HTML5

    1
    Matheus Oliveira•160
    @matebeingPosted over 2 years ago

    Good job, Sohila!

    There are some accessibility issues on your HTML, it seems you have assigned invalid values to the role attribute and you do not have used the semantics tags, but It is easy to fix! Try to check out the report of your solution scrolling down and clicking on the CTA button on your solution page. Plus, try to insert padding only to the left side to the paragraph element inside the avatar box div and adding to its parent align-items: center, so you'll have the elements centered properly.

    You did a great work! Keep on going.

    0
  • Mofe•440
    @Mofe620Submitted over 2 years ago

    This one felt pretty straightforward. However, I know I might have done somethings wrongly. I'd really appreciate corrections. Thanks a whole lot.

    QR Component using HTML, CSS

    1
    Matheus Oliveira•160
    @matebeingPosted over 2 years ago

    Well done, Mofe! I'd suggest you to avoid using using width/height directly to the HTML tag, instead, try to style the body element. If you want to center your card, you can do it using flexbox on body and setting its width 100% and height 100vh and then your card will be centered in the middle of the page, both vertically and horizontally.

    Marked as helpful
    2