Skip to content
Submitted over 2 years ago

just used: CSS3 and HTML5

sto•60
@Sohila-Samir
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I'm more of a backender so I'm not so good with CSS yet. I'd appreciate if you can review my style.css file and give feedback on the code and if there's anything I can improve or change. thanks in advance :)

Community feedback

  • Matheus Oliveira•160
    @matebeingPosted over 2 years ago

    Good job, Sohila!

    There are some accessibility issues on your HTML, it seems you have assigned invalid values to the role attribute and you do not have used the semantics tags, but It is easy to fix! Try to check out the report of your solution scrolling down and clicking on the CTA button on your solution page. Plus, try to insert padding only to the left side to the paragraph element inside the avatar box div and adding to its parent align-items: center, so you'll have the elements centered properly.

    You did a great work! Keep on going.

    0
    sto•60
    @Sohila-SamirPosted over 2 years ago

    @matebeing thanks for your replay. much appreciated. I've already fixed the accessibility issues a while ago. only one left that required me to add at least one heading but I left it for the sake of having an identical design.

    also surely will consider your recommendation :) have a great day

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord