@marsh189
@AmanoLX
Submitted
What are you most proud of, and what would you do differently next time?
Passing info from the data.js through different components. All works fine.
What challenges did you encounter, and how did you overcome them?
How to structure the social links in the data.js file correctly.
What specific areas of your project would you like help with?
Any other ideas on how to structure the data.js differently are welcome!
@marsh189
Posted
I think the way to formatted the data.js is just fine. Everything is well named and holds all the info needed to display the Cards correctly. Setting the profile in a 'people' list means that your program is ready to fill in multiple of these social link cards when more people are added to the data! Great work!
Marked as helpful
@EFEELE
Submitted
What are you most proud of, and what would you do differently next time?
I really liked this challenge!
What challenges did you encounter, and how did you overcome them?
I had hardly used transform translate in the animations of my projects, so it was good to practice it here, it really isn't complicated.
What specific areas of your project would you like help with?
I want to know everything about good practices of responsive design
@marsh189
Posted
The animation looks great and it all looks as expected. One question I had, and it may be something that I am unaware of, but why did you use a div with a background image for the avatar instead of just using an img?
@Weslley-Souza32
Submitted
What are you most proud of, and what would you do differently next time?
Me orgulho de conseguir centralizar meu container certinho e também de conseguir adicionar o footer no fim da pagina sem afetar a centralização do meu container.
What challenges did you encounter, and how did you overcome them?
O maior desafio era conseguir colocar o meu footer no fim da pagina sem afetar muito o meu container, pois antes eu estava usando padding-top ou margin-top no meu footer e ele empurrava o container para o topo da pagina. Resolvi criando uma div que envolvia todo meu container nela coloquei estas propriedades: display: flex; flex-direction: column; min-height: 100vh;
e no meu container adicionei um margin: auto junto das propriedades que já cotiam.
What specific areas of your project would you like help with?
Formas talves melhores de centralizar um container com flex ou grid.
@marsh189
Posted
I believe this works perfectly well, however there are a couple places that stick out to me. First I would look at adjusting the padding around the whole component. The sides look a lot thinner around the image than it does at the top of the image while there is a lot of empty space at the bottom. Also, another small thing I would consider is to play around with the border radius. To me, it looks like it could be a little higher.
Marked as helpful
