@tannguyenk3Submitted 4 months ago
P
Marcus Daniels
@marjskyAll comments
- @marjskyPosted 3 months ago
Your codebase is readable and easy to understand. One thing advice is to remove unnecessary files such as template documents and guides at the root directory. Otherwise you may pull together create folder so up to developer curious check in.
0 - @BlanchevalenSubmitted about 1 year agoWhat are you most proud of, and what would you do differently next time?
I was created this a long time ago. I will use BEM next time.
What challenges did you encounter, and how did you overcome them?I was just doing my job.
What specific areas of your project would you like help with?None. Thanks.
- @almendevSubmitted 5 months agoWhat challenges did you encounter, and how did you overcome them?
I tried to use em and rem units for everything to improve accessibility and responsiveness.
What specific areas of your project would you like help with?I would like to fined a better way to define the spaces between the card inner elements.
@marjskyPosted 5 months agoYour website is perfect match to design requirement. In HTML file, your structure look neat and sense everything. Your implementation in CSS is completed without missing or vague coordinate to HTML document. Good job!
Marked as helpful1 - @SDprasanth0012Submitted 5 months ago@marjskyPosted 5 months ago
Your website look great! There are few aspects to may needed to revise: There is missing first capital letter for omelette in the title of article. Bold words should be wenge brown. Numbers should be slightly bold, add indent space, and brandy red. On mobile screens, the list under preparation time and ingredients should have consistent bullet indentation alignment.
0 - @bttrvng99Submitted 7 months agoWhat are you most proud of, and what would you do differently next time?
Getting the colors right and styling the hyperlinks as buttons
What challenges did you encounter, and how did you overcome them?- How to center the card and allow it to be scrollable when zoomed in, by setting height to the document as 100%
How to use local fonts in CSS file instead of linking them in HTML, how to get the size and length of all element right
@marjskyPosted 7 months agoBoth HTML and CSS files are clean codebase, readable, and consistency, great start off! I can see you have comment out using local fonts in CSS file, it look neat no explain needed.
0 - @vijeth-kharviSubmitted 7 months agoWhat are you most proud of, and what would you do differently next time?
i have implemented few changes that i got as feedback from my last task submission
What challenges did you encounter, and how did you overcome them?.
What specific areas of your project would you like help with?.
@marjskyPosted 7 months agoI wonder you able to access and use either Sketch or Figma design files because these provide you accurate details of design specs. Other than, you did show your great effort start creating amazingly website page.
Recommend practice as pro developer to follow handoff document(Sketch or Figma) so that managers/clients love to complete checkpoints status of your process work.
Marked as helpful1 - @Juan1423Submitted 8 months agoWhat are you most proud of, and what would you do differently next time?
First introduction to css without GPT
First test the simples solution before go on with more complex solutions, because i see so much and tried to use, fail hard and waste a lot of time.
What challenges did you encounter, and how did you overcome them?Don`t know how to center a div xD
Most of thing just with some time I get it, but center a div make me so confused that I try everything to the simples ones up to more difficult ones and return to simples ones, just more slowly and it work.
What specific areas of your project would you like help with?I`m here to use css efficiently and responsive
So if I could recive advice about hoe to use more clean css and assure the sites I design are responsive I gradly accept.
@marjskyPosted 8 months agoI see that you are using individual margin properties throughout your embedded CSS. I would like to suggest considering shorthand properties for margins to streamline your code and improve readability.
1
