All comments

• 

  guymanevych•10

  @guyguy101Submitted about 1 year ago

  I would ask for any feedback. from best practices to making the code cleaner.

  

  Full solution for QR component challenge

  1

  90
  

  Marek_Ćwioro•50

  @marek4882Posted about 1 year ago

  Hi, this is my advice:

  1. Use more semantic tags for improved structure.
  2. Change the first paragraph to an <h1> tag.
  3. Provide more meaningful class descriptions, e.g., replace "text-1" with "card-title" and "text-2" with "card-text."
  4. Instead of "height: 100vh" on the body, use "min-height"
  5. Always have a main landmark on the page, even if only building one component
  6. You are missing the box-shadow on the card as shown in the design.

  Marked as helpful

  0