Design comparison
SolutionDesign
Solution retrospective
I would ask for any feedback. from best practices to making the code cleaner.
Community feedback
- @marek4882Posted about 1 year ago
Hi, this is my advice:
- Use more semantic tags for improved structure.
- Change the first paragraph to an <h1> tag.
- Provide more meaningful class descriptions, e.g., replace "text-1" with "card-title" and "text-2" with "card-text."
- Instead of "height: 100vh" on the body, use "min-height"
- Always have a main landmark on the page, even if only building one component
- You are missing the box-shadow on the card as shown in the design.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord