Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Full solution for QR component challenge

@guyguy101

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


I would ask for any feedback. from best practices to making the code cleaner.

Community feedback

@marek4882

Posted

Hi, this is my advice:

  1. Use more semantic tags for improved structure.
  2. Change the first paragraph to an <h1> tag.
  3. Provide more meaningful class descriptions, e.g., replace "text-1" with "card-title" and "text-2" with "card-text."
  4. Instead of "height: 100vh" on the body, use "min-height"
  5. Always have a main landmark on the page, even if only building one component
  6. You are missing the box-shadow on the card as shown in the design.

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord