Skip to content
OverviewSolutions
6
Comments
3
Maksim Deviatilov
@maksimcoder

All comments

  • Maksim Deviatilov•185
    @maksimcoderPosted almost 2 years ago

    Hello, nice work you've done! I've only 1 thing I saw. When creating a button with outline style it's better to use border rather than outline. Additionally, you might have noticed that button's size is like bouncing when hovering it that happens due to the absence of border property on not hovered button state. So what I suggest exactly: 1 - for outline button style use borders 2 - to make styling look natively use border: *px solid transparent on not hover state and on hover state use border style you wish.

    Thanks for reading, happy coding!

    Marked as helpful
    0
  • Rayane•1,935
    @RayaneBengaouiSubmitted over 3 years ago

    Hello everyone ! 🙂

    I tried to tackle this challenge in around ~30min.

    Any feedback is appreciated !

    Have a nice day ☀️

    3-column component - HTML/CSS

    3
    Maksim Deviatilov•185
    @maksimcoderPosted over 3 years ago

    Hello, Rayane, I was looking through your work after your comments on mine and spotted some issues. In mobile (375px) width, middle card top borders have radius, while two other cards don't. This is a little thing but still I wanted you to know it. 😁 Also, some margins, according to the mobile-design file, should be done. That's all I wanted to share with you, I take your work as a great example. Have a nice weekend!

    1
  • aayushi simzia•355
    @iucsimSubmitted almost 4 years ago

    Hello everyone,

    It was an awesome challenge I've learned a lot while making it. I took 3 days for completing it. I'm very much new to Javascript so I spent more time in Javascript.

    In future I really want to make this project in React.

    Do feedback me So I can improve JS :)

    Thanks and looking forward to your feedback!

    Todo App using HTML, CSS, Sass and Javascript

    1
    Maksim Deviatilov•185
    @maksimcoderPosted almost 4 years ago

    Hello, Aayushi, I've looked through your JS code and have some tips for you as I would do if I were you.

    1. When you create a function createtodoElement(val) use Class in order to automate and avoid repeating your code.
    2. When you're adding an eventListener on footer buttons, use cycles or forEach method to automate the process. (activeBtn.classList.remove("active"); completedBtn.classList.remove("active"); => footerBtns.forEach(item => item.classList.remove('active');) I hope this tips will help you in future even if you knew them before. By the way, I'm currently working on this project and that's awesome that you did it!
    0